Conversation
|
@stephanbcbauer : issues should be fixed |
|
@eclipse-tractusx/automotive-tractusx-committers i am not available for the next days, please support here to merge the changes. They are relevant for Release 25.12 Thx |
|
Please add this KIT to the master data |
stephanbcbauer
left a comment
There was a problem hiding this comment.
Thanks for your contribution:
- Could you please add the *.license files for the svg
- Please use kebapb-case for the svg names
- PLease add the KIT to masterdata if not already done
- res.text can be deleted?
- only adaption-view seems to have content. What about the other files?
docs-kits/kits/cbam-kit/res/res.txt
Outdated
| @@ -0,0 +1 @@ | |||
| 1 | |||
There was a problem hiding this comment.
this file could be deleted?
matbmoser
left a comment
There was a problem hiding this comment.
please make sure you include in the kit master data the information about this kit!
https://eclipse-tractusx.github.io/docs/release/trg-10/trg-10-01#master-data
|
Also please add the license for your images :) https://eclipse-tractusx.github.io/docs/release/trg-7/trg-7-07 |
|
we also need a cool logo @Grand-Thibault |
we are waiting fot the logo |
@Grand-Thibault is already working on it |
1,2,4,5 done; 3 waiting for logo |
done in update |
|
Good morning, after review/discussion with @ther3sa and @jSchuetz88 @matbmoser what about the icon/logo. Do you provide a new one here? What about the @wehrstedt-jan , @martinaprox This PR needs to be merged today/tomorrow because we need to execute the versioning plug-in tomorrow, to prepare the release 25.12 To provide the state for the KIT, please merge main into your branch. For more details about the new structure, please ask @matbmoser |
martinaprox
left a comment
There was a problem hiding this comment.
Review done together with Johannes Wunderlich and Martin Jarosch-Mitko and approved for release.
|
After discussion in standardization hour ⇾ KIT will be provided as soon as possible. Expected milestone would be 26.03. |
|
will be shifted to 2603 Pull Request will be reopened as asoon logo is available |
I agree on removing the old images. |
There was a problem hiding this comment.
@lgblaumeiser why to remove the dataplane?
This is how it is working now. If it changes in the future, it shall be updated in the future.
There was a problem hiding this comment.
I did not complain on that picture :-). It might change, but that is future
There was a problem hiding this comment.
I did saw it with missing data then,.
There was a problem hiding this comment.
I restored the original architecture picture as shown above which is now described in the development view.
|
I've been trying to delete the unused images since Monday. However, the delete command isn't working for me. |
matbmoser
left a comment
There was a problem hiding this comment.
Since I have done the logo I need to add the copyright from my company.
There was a problem hiding this comment.
I did saw it with missing data then,.
lol |
|
@Jarosch-Mitko would it be fine to add it like it was before the diagram? and should be like this:
so we are also concise with what is happening and the interactions between systems. I commented to Lars that if we also abstract too much it is then not very clear what interacts with what. |
|
I need to override your branch @Jarosch-Mitko I have stored a backup so we dont lose your changes. Working on your main is not a good option, please create a separated branch next time, this confuses GitHub and creates a "fork" which is different to the latest version, not allowing me to merge this PR. So in the end everything got invalid when I started to resolve conflicts. So at the end was more easy to close and sync you branch fork with our main, and create a clean PR with your latest changes. |
|
Dont worry I am just fixing your branch. |
|
This PR was invalid, since the commit history was destroyed at some point, and I could not fix it. Have created a clean one here: #1495 |






Description
This PR covers the first version of the CBAM KIT, adressing the Catena-X solution for the Carbon border adjustment mechanism. It contains a descrition of the CBAM process and the initial data model for the exchange of data between the importer/declarant and supplier.
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: